lkml.org 
[lkml]   [2019]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 01/15] habanalabs: add skeleton driver
On Wed, Jan 23, 2019 at 1:01 AM Oded Gabbay <oded.gabbay@gmail.com> wrote:

> diff --git a/drivers/misc/habanalabs/include/habanalabs_device_if.h b/drivers/misc/habanalabs/include/habanalabs_device_if.h
> new file mode 100644
> index 000000000000..9dbb7077eabd
> --- /dev/null
> +++ b/drivers/misc/habanalabs/include/habanalabs_device_if.h

Since this is a apparently a user space ABI, the file should be in
include/uapi/linux/,
not in the driver directory.

> +/* must be aligned to 4 bytes */
> +struct armcp_info {
> + struct armcp_sensor sensors[ARMCP_MAX_SENSORS];
> + __u8 kernel_version[VERSION_MAX_LEN];
> + __u32 reserved[3];
> + __u32 cpld_version;
> + __u32 infineon_version;
> + __u8 fuse_version[VERSION_MAX_LEN];
> + __u8 thermal_version[VERSION_MAX_LEN];
> + __u8 armcp_version[VERSION_MAX_LEN];
> + __u64 dram_size;
> +};

The compiler will align this to 8 bytes on most architectures, and
add another padding field before dram_size. Better remove the
'reserved' fields, or make them an even number.

Arnd

\
 
 \ /
  Last update: 2019-01-26 17:07    [W:0.319 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site