Messages in this thread | | | From | "Raslan, KarimAllah" <> | Subject | Re: [PATCH v5 08/13] KVM/nVMX: Use kvm_vcpu_map when mapping the posted interrupt descriptor table | Date | Fri, 25 Jan 2019 18:15:20 +0000 |
| |
On Wed, 2019-01-23 at 13:03 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 09, 2019 at 10:42:08AM +0100, KarimAllah Ahmed wrote: > > > > Use kvm_vcpu_map when mapping the posted interrupt descriptor table since > > using kvm_vcpu_gpa_to_page() and kmap() will only work for guest memory > > that has a "struct page". > > > > One additional semantic change is that the virtual host mapping lifecycle > > has changed a bit. It now has the same lifetime of the pinning of the > > interrupt descriptor table page on the host side. > > Is the description stale? I am not seeing how you are changing the > semantics here. You follow the same path - map/unmap. > > Could you expand please?
This is pretty much the same case as in 7/13, it's just two different life-cycle changes and I dropped one of them and the other one is still there :D
> > > > > > > Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de> > > --- > > v4 -> v5: > > - unmap with dirty flag > > > > v1 -> v2: > > - Do not change the lifecycle of the mapping (pbonzini)
Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich Ust-ID: DE 289 237 879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
| |