lkml.org 
[lkml]   [2019]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times
    On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote:
    > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote:
    > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY
    > > to happen for more than once.
    > >
    > > Signed-off-by: Peter Xu <peterx@redhat.com>
    >
    > So it would be nice to add a comment in the code and in the commit message
    > about possible fault starvation (mostly due to previous patch changes) as
    > if some one experience that and try to bisect it might overlook the commit.
    >
    > Otherwise:
    >
    > Reviewed-by: Jérôme Glisse <jglisse@redhat.com>

    Jerome, can I still keep this r-b if I'm going to fix the starvation
    issue you mentioned in previous patch about lock page?

    Regards,

    --
    Peter Xu

    \
     
     \ /
      Last update: 2019-01-24 08:06    [W:2.813 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site