lkml.org 
[lkml]   [2019]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing to use testvec_configs
    On Thu, Jan 24, 2019 at 01:36:23PM +0100, Ard Biesheuvel wrote:
    > On Wed, 23 Jan 2019 at 23:53, Eric Biggers <ebiggers@kernel.org> wrote:
    > >
    > > From: Eric Biggers <ebiggers@google.com>
    > >
    > > Convert alg_test_skcipher() to use the new test framework, adding a list
    > > of testvec_configs to test by default. When the extra self-tests are
    > > enabled, randomly generated testvec_configs are tested as well.
    > >
    > > This improves skcipher test coverage mainly because now all algorithms
    > > have a variety of data layouts tested, whereas before each algorithm was
    > > responsible for declaring its own chunked test cases which were often
    > > missing or provided poor test coverage. The new code also tests both
    > > the MAY_SLEEP and !MAY_SLEEP cases, different IV alignments, and buffers
    > > that cross pages.
    > >
    > > This has already found a bug in the arm64 ctr-aes-neonbs algorithm.
    > > It would have easily found many past bugs.
    > >
    > > I removed the skcipher chunked test vectors that were the same as
    > > non-chunked ones, but left the ones that were unique.
    > >
    > > Signed-off-by: Eric Biggers <ebiggers@google.com>
    >
    > This patch does not apply after applying 1..10 onto cryptodev/master
    >
    > Do you have a tree somewhere?

    Hello

    I got the same with next.
    You need to apply "crypto: clarify name of WEAK_KEY request flag" from his repo:
    https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git branch testmgr-improvements

    Regards

    \
     
     \ /
      Last update: 2019-01-24 14:15    [W:4.412 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site