Messages in this thread | | | Subject | Re: [PATCH] arm64: dts: hikey: Revert "Enable HS200 mode on eMMC" | From | Robin Murphy <> | Date | Thu, 24 Jan 2019 11:18:42 +0000 |
| |
Hi John,
On 23/01/2019 20:06, John Stultz wrote: > From: Alistair Strachan <astrachan@google.com> > > This reverts commit abd7d0972a192ee653efc7b151a6af69db58f2bb. This > change was already partially reverted by John Stultz in commit > 9c6d26df1fae ("arm64: dts: hikey: Fix eMMC corruption regression"). > > This change appears to cause controller resets and block read failures > which prevents successful booting on some hikey boards.
FWIW, you might want to have a play with the pinctrl settings - I've seen various flakiness with HS200 eMMCs on Rockchip boards which could be solved by bumping up the drive strength.
Robin.
> Cc: Ryan Grachek <ryan@edited.us> > Cc: Wei Xu <xuwei5@hisilicon.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: stable <stable@vger.kernel.org> #4.17+ > Signed-off-by: Alistair Strachan <astrachan@google.com> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 6102350..7092460 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -300,7 +300,6 @@ > > dwmmc_0: dwmmc0@f723d000 { > cap-mmc-highspeed; > - mmc-hs200-1_8v; > non-removable; > bus-width = <0x8>; > vmmc-supply = <&ldo19>; >
| |