Messages in this thread | | | Date | Thu, 24 Jan 2019 09:42:21 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 5/5] virtio-blk: Consider virtio_max_dma_size() for maximum segment size |
| |
On Thu, Jan 24, 2019 at 09:40:11AM +0100, Joerg Roedel wrote: > > I wonder if we should just move the dma max segment size check > > into blk_queue_max_segment_size so that all block drivers benefit > > from it. Even if not I think at least the SCSI midlayer should > > be updated to support it. > > In that case the limit would also apply to virtio-blk even if it doesn't > use the DMA-API. If that is acceptable we can move the check to > blk_queue_max_segment_size().
Yes. But more importantly it would fix the limit for all other block drivers that set large segment sizes when running over swiotlb.
| |