lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST
    From
    Date
    On Jan 23, 2019, at 7:08 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:

    > Thanks for catching this!
    >
    > Although I think we should fix this in a different way. The problem
    > here is that the shrink cannot proceed because there was a previous
    > rehash that is still incomplete. We should wait for its completion
    > and then reattempt a shrinnk should it still be necessary.
    >
    > So something like this:

    SGTM.

    I can't test this right now because our VM server's down after a power
    outage this evening, but I tried a similar patch that swallowed the
    -EEXIST err and even with that oversight the hashtable dodged the
    reschedule loop.

    - Josh

    \
     
     \ /
      Last update: 2019-01-24 04:40    [W:6.327 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site