Messages in this thread | | | Date | Wed, 23 Jan 2019 22:03:33 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 3/7] coresight: Use event attributes for sink selection |
| |
On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote: > + /* First get the selected sink from user space. */ > + sink = coresight_get_sink_by_id(event->attr.config2);
(I know there's a new version out, I'll go look there shortly)
should this patch not also have something like:
PMU_FORMAT_ATTR(sinkid, "config2:0-63");
> + if (!sink) > + sink = coresight_get_enabled_sink(true); > if (!sink || !sink_ops(sink)->alloc_buffer) > goto err;
| |