lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name
From
Date
Pls ignore this err patch.

On 2019/1/23 17:07, YueHaibing wrote:
> In case DOC_CHIPID_G3, mtd->name is not freed in err handling path,
> which is alloced by kasprintf(). Fix this by using devm_kasprintf().
>
> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: use devm_kasprintf
> ---
> drivers/mtd/devices/docg3.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 4c94fc0..af824d3 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1767,8 +1767,8 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
>
> switch (chip_id) {
> case DOC_CHIPID_G3:
> - mtd->name = kasprintf(GFP_KERNEL, "docg3.%d",
> - docg3->device_id);
> + mtd->name = devm_kasprintf(GFP_KERNEL, "docg3.%d",
> + docg3->device_id);
> if (!mtd->name)
> return -ENOMEM;
> docg3->max_block = 2047;
>

\
 
 \ /
  Last update: 2019-01-23 10:10    [W:0.036 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site