lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 2/3] sched/fair: update scale invariance of PELT
From
Date
On 1/16/19 10:43 AM, Vincent Guittot wrote:

[...]

> +static inline u64 rq_clock_pelt(struct rq *rq)
> +{

Doesn't this function need

lockdep_assert_held(&rq->lock);
assert_clock_updated(rq);

like rq_clock() and rq_clock_task()? Later to support commit
cb42c9a3ebbb "sched/core: Add debugging code to catch missing
update_rq_clock() calls".

> + return rq->clock_pelt - rq->lost_idle_time;
> +}

[...]

\
 
 \ /
  Last update: 2019-01-23 09:26    [W:0.058 / U:2.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site