Messages in this thread | | | From | John Stultz <> | Date | Tue, 22 Jan 2019 16:27:27 -0800 | Subject | Re: [PATCH 5/8 v4] dma: k3dma: Add support for dma-channel-mask |
| |
On Thu, Jan 17, 2019 at 9:14 AM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > /* Skip the channels which are masked */ > if ((d->dma_channel_mask) & BIT(pch)) > continue;
Per the discussion w/ Vinod and Rob, I think I'll leave this bit be, so we use the channels in the bitmask.
> PS: Use BIT() macro where applicable.
But this suggestions I've integrated for v5.
Thanks so much for the review! -john
| |