lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 058/111] RDMA/nldev: Dont expose unsafe global rkey to regular user
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Leon Romanovsky <leonro@mellanox.com>

    commit a9666c1cae8dbcd1a9aacd08a778bf2a28eea300 upstream.

    Unsafe global rkey is considered dangerous because it exposes memory
    registered for all memory in the system. Only users with a QP on the same
    PD can use the rkey, and generally those QPs will already know the
    value. However, out of caution, do not expose the value to unprivleged
    users on the local system. Require CAP_NET_ADMIN instead.

    Cc: <stable@vger.kernel.org> # 4.16
    Fixes: 29cf1351d450 ("RDMA/nldev: provide detailed PD information")
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/core/nldev.c | 4 ----
    1 file changed, 4 deletions(-)

    --- a/drivers/infiniband/core/nldev.c
    +++ b/drivers/infiniband/core/nldev.c
    @@ -580,10 +580,6 @@ static int fill_res_pd_entry(struct sk_b
    if (nla_put_u64_64bit(msg, RDMA_NLDEV_ATTR_RES_USECNT,
    atomic_read(&pd->usecnt), RDMA_NLDEV_ATTR_PAD))
    goto err;
    - if ((pd->flags & IB_PD_UNSAFE_GLOBAL_RKEY) &&
    - nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_UNSAFE_GLOBAL_RKEY,
    - pd->unsafe_global_rkey))
    - goto err;

    if (fill_res_name_pid(msg, res))
    goto err;

    \
     
     \ /
      Last update: 2019-01-21 15:20    [W:4.277 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site