Messages in this thread | | | Date | Mon, 21 Jan 2019 16:19:42 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/3] PCI: hv: Allocate physically contiguous hypercall params buffer |
| |
On Fri, Jan 18, 2019 at 02:17:16AM +0530, Ajay Kaher wrote: > hv_do_hypercall() assumes that we pass a segment from a physically > contiguous buffer. A buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Use kmalloc() to allocate this buffer. >
Since you're going to need to resend this anyway, can you add in the commit message what this looks like from a user perspective? Presumably it's an occasional crash?
regards, dan carpenter
| |