Messages in this thread | | | From | Ard Biesheuvel <> | Date | Mon, 21 Jan 2019 11:43:14 +0100 | Subject | Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver |
| |
On Mon, 21 Jan 2019 at 11:30, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote: > > --- /dev/null > > +++ b/drivers/char/hw_random/optee-rng.c > > @@ -0,0 +1,272 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > Nice, but: > > <snip> > > > +MODULE_LICENSE("GPL"); > > This string means "GPL2+", you need "GPLv2" here instead. >
I think you need a space there: "GPL v2" or it doesn't get picked up correctly (or at least, it didn't use to)
> Yeah, it's a pain, and everyone gets it wrong, we need to add a > checkpatch.pl rule for this to keep it from being added in new code. > > thanks, > > greg k-h
| |