Messages in this thread | | | Subject | RE: [PATCH] PM / devfreq: fix mem leak and missing check of return value in devfreq_add_device() | From | MyungJoo Ham <> | Date | Mon, 21 Jan 2019 10:22:08 +0900 |
| |
> 'devfreq' is malloced in devfreq_add_device() and should be freed in > the error handling cases, otherwise it will cause memory leak. > > devm_kzalloc() could fail, so insert a check of its return value. And > if it fails, returns -ENOMEM. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Dear Yangtao,
Could you please make your patch without indentation style changes?
The label, "err_devfreq", would fit more if it's renamed "err_kzalloc".
Cheers, MyungJoo.
| |