Messages in this thread | | | Subject | Re: [PATCH 1/2] hwmon (occ): Fix license headers | From | Guenter Roeck <> | Date | Mon, 21 Jan 2019 16:40:24 -0800 |
| |
On 1/21/19 1:15 PM, Eddie James wrote: > > > On 01/21/2019 02:19 PM, Joel Stanley wrote: >> On Tue, 22 Jan 2019 at 06:56, Eddie James <eajames@linux.ibm.com> wrote: >> >>> --- a/drivers/hwmon/occ/common.h >>> +++ b/drivers/hwmon/occ/common.h >>> @@ -1,4 +1,5 @@ >>> -/* SPDX-License-Identifier: GPL-2.0 */ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> +// Copyright IBM Corp 2019 >> We want to use the /* */ syntax for headers. Take a closer look at >> Documentation/process/license-rules.rst: > > Oops. Do I put the copyright in the copyright in the same comment block then? Or use // for that?
Separate comment block. The SPDX comment block is expected to be on its own. But please don't make it even more messy than it already is by using // subsequently for the IBM copyright.
Guenter
> >> >> 2. Style: >> >> The SPDX license identifier is added in form of a comment. The comment >> style depends on the file type:: >> >> C source: // SPDX-License-Identifier: <SPDX License Expression> >> C header: /* SPDX-License-Identifier: <SPDX License Expression> */ >> > >
| |