Messages in this thread | | | Date | Mon, 21 Jan 2019 15:30:30 +0100 | From | Stefan Agner <> | Subject | Re: [PATCH] ARM: dts: imx6qdl-apalis: add phy-supply |
| |
On 18.01.2019 14:32, Stefan Agner wrote: > Use the VDD I/O rail as phy-supply regulator. Technically, the > regulator has multiple rails, but currently the driver only > supports a single phy-supply. The VDD I/O rail has the highest > power consumption when software power down is used and hence > the highest saving potential.
Please don't merge this patch. The vgen5_reg is also used as a pull-up for USB ID pin, it would not be safe for the FEC driver to disable this rail.
-- Stefan
> > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 0b47aecf336a..cf66f9ececbd 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -241,6 +241,7 @@ > phy-handle = <ðphy>; > phy-reset-duration = <10>; > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > + phy-supply = <&vgen5_reg>; > status = "okay"; > > mdio {
| |