Messages in this thread | | | Date | Sun, 20 Jan 2019 19:40:43 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf top: Fix wrong hottest instruction highlighted |
| |
On Mon, Jan 21, 2019 at 12:05:22AM +0800, He Kuang wrote: > Annotation line's percentage is compared and inserted into rbtree, but the > percent field of 'struct annotation_data' is an array, the comparison > result between them is the address difference. > > This patch compares the right slot of percent array according to > opts->percent_type and makes things right. > > The problem can be reproduced by pressing 'H' in perf top annotation view. > It should highlight the instruction line which has the highest sampling > percentage. > > Signed-off-by: He Kuang <hekuang@huawei.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
| |