lkml.org 
[lkml]   [2019]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 09/16] block: sed-opal: split generation of bytestring header and content
On Thu, Jan 17, 2019 at 09:31:49PM +0000, David Kozub wrote:
> -
> - memcpy(&cmd->cmd[cmd->pos], bytestring, len);
> + start = &cmd->cmd[cmd->pos];
> cmd->pos += len;

This is somewhat pendatic, but it helps me review patches if we keep things together.
Since we're no longer doing the memcpy in this function, can we please move the cmd->pos += len
to the location where we actually do the memcpy.

I'm willing to be told to get over it if other reviewers don't like that approach, but if no one cares
please move it.


> + return start;
> +}
>
> +static void add_token_bytestring(int *err, struct opal_dev *cmd,
> + const u8 *bytestring, size_t len)
> +{
> + u8 *start;
> +
> + start = add_bytestring_header(err, cmd, len);
> + if (!start)
> + return;
> + memcpy(start, bytestring, len);

Do the above here instead.

> 2.20.1
>
>

\
 
 \ /
  Last update: 2019-01-19 18:01    [W:0.032 / U:2.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site