lkml.org 
[lkml]   [2019]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] Provide in-kernel headers for making it easy to extend the kernel
    On Sat, Jan 19, 2019 at 09:25:32AM +0100, Greg KH wrote:
    > On Fri, Jan 18, 2019 at 05:55:43PM -0500, Joel Fernandes wrote:
    > > --- /dev/null
    > > +++ b/kernel/kheaders.c
    > > @@ -0,0 +1,74 @@
    > > +// SPDX-License-Identifier: GPL-2.0
    >
    > Nice, but:
    >
    > <snip>
    >
    > > +MODULE_LICENSE("GPL");
    >
    > That means "GPL2+" (yeah, horrible, I know, we all get it wrong, look at
    > include/linux/module.h for details)
    >
    > So you should change that line to:
    > MODULE_LICENSE("GPLv2");

    Ok, will fix.

    > Other than that, nice work.

    thanks!

    - Joel

    \
     
     \ /
      Last update: 2019-01-19 17:28    [W:4.213 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site