Messages in this thread | | | Date | Fri, 18 Jan 2019 16:55:41 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2] driver core: move device->knode_class to device_private |
| |
On Fri, Jan 18, 2019 at 10:34:59AM +0800, Wei Yang wrote: > As the description of struct device_private says, it stores data which > is private to driver core. And it already has similar fields like: > knode_parent, knode_driver, knode_driver and knode_bus. This look it is > more proper to put knode_class together with those fields to make it > private to driver core. > > This patch move device->knode_class to device_private to make it comply > with code convention. > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks for this. There are a number of other variables that should move into this structure, if you want to take a look into doing that.
greg k-h
| |