Messages in this thread | | | Date | Wed, 16 Jan 2019 22:35:16 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 09/13] arm64: dts: qcom: qcs404: Add OPP table |
| |
On Mon 17 Dec 01:46 PST 2018, Jorge Ramirez-Ortiz wrote:
> Add a CPU OPP table to qcs404 > > Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 9b5c165..4594fea7 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -62,6 +62,21 @@ > }; > }; > > + cpu_opp_table: cpu_opp_table {
Please don't use _ in the node name. (cpu_opp_table: cpu-opp-table)
Apart from that, this looks good
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards, Bjorn
> + compatible = "operating-points-v2"; > + opp-shared; > + > + opp-1094400000 { > + opp-hz = /bits/ 64 <1094400000>; > + }; > + opp-1248000000 { > + opp-hz = /bits/ 64 <1248000000>; > + }; > + opp-1401600000 { > + opp-hz = /bits/ 64 <1401600000>; > + }; > + }; > + > firmware { > scm: scm { > compatible = "qcom,scm-qcs404", "qcom,scm"; > -- > 2.7.4 >
| |