lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] perf scripts python: Add Python 3 support to futex-contention.py
    Date
    Support both Python 2 and Python 3 in futex-contention.py.
    ``print`` is now a function rather than a statement. This should
    have no functional change.

    The "has_key()" method is deprecated in favor of the "in" operator.
    So incorporate those changes here.

    Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
    Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>

    Please enter the commit message for your changes. Lines starting
    ---
    tools/perf/scripts/python/futex-contention.py | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf/scripts/python/futex-contention.py
    index 0f5cf43..794a9f0 100644
    --- a/tools/perf/scripts/python/futex-contention.py
    +++ b/tools/perf/scripts/python/futex-contention.py
    @@ -9,6 +9,7 @@
    # to perf python scripting.
    #
    # Measures futex contention
    +from __future__ import print_function

    import os, sys
    sys.path.append(os.environ['PERF_EXEC_PATH'] + '/scripts/python/Perf-Trace-Util/lib/Perf/Trace')
    @@ -33,18 +34,18 @@ def syscalls__sys_enter_futex(event, ctxt, cpu, s, ns, tid, comm, callchain,

    def syscalls__sys_exit_futex(event, ctxt, cpu, s, ns, tid, comm, callchain,
    nr, ret):
    - if thread_blocktime.has_key(tid):
    + if (tid in thread_blocktime):
    elapsed = nsecs(s, ns) - thread_blocktime[tid]
    add_stats(lock_waits, (tid, thread_thislock[tid]), elapsed)
    del thread_blocktime[tid]
    del thread_thislock[tid]

    def trace_begin():
    - print "Press control+C to stop and show the summary"
    + print("Press control+C to stop and show the summary")

    def trace_end():
    for (tid, lock) in lock_waits:
    min, max, avg, count = lock_waits[tid, lock]
    - print "%s[%d] lock %x contended %d times, %d avg ns" % \
    - (process_names[tid], tid, lock, count, avg)
    + print("%s[%d] lock %x contended %d times, %d avg ns" % \
    + (process_names[tid], tid, lock, count, avg))

    --
    1.8.3.1
    \
     
     \ /
      Last update: 2019-01-17 10:47    [W:3.227 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site