Messages in this thread | | | Date | Thu, 17 Jan 2019 00:17:29 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 2/2] tpm/eventlog/tpm1: Fix off-by-1 when reading binary_bios_measurements |
| |
On Fri, Jan 11, 2019 at 04:59:33PM +0800, Jia Zhang wrote: > It is unable to read the entry when it is the only one in > binary_bios_measurements: > > 00000000 00 00 00 00 08 00 00 00 c4 2f ed ad 26 82 00 cb > 00000010 1d 15 f9 78 41 c3 44 e7 9d ae 33 20 00 00 00 00 > 00000020 > > This is obviously a firmware problem on my linux machine: > > Manufacturer: Inspur > Product Name: SA5212M4 > Version: 01 > > However, binary_bios_measurements should return it any way, > rather than nothing, after all its content is completely > valid. > > Fixes: 55a82ab("tpm: add bios measurement log") > Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
LGTM, Nayna?
/Jarkko
| |