lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that
    Date
    Deny autoidle for hwmods with the OCPIF_SWSUP_IDLE flag,
    that makes hwmods working properly which cannot handle
    autoidle properly in lower power states.
    Affected is e. g. the omap_hdq.
    Since an ick might have mulitple users, autoidle is disabled
    when an individual user requires that rather than in
    _setup_iclk_autoidle. dss_ick is an example for that.

    Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
    ---
    Comments to v1 to this patch were worked into a new 2/3
    ---
    arch/arm/mach-omap2/omap_hwmod.c | 16 ++++++++++++----
    1 file changed, 12 insertions(+), 4 deletions(-)

    diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
    index b5531dd3ae9c..3a04c73ac03c 100644
    --- a/arch/arm/mach-omap2/omap_hwmod.c
    +++ b/arch/arm/mach-omap2/omap_hwmod.c
    @@ -1002,8 +1002,10 @@ static int _enable_clocks(struct omap_hwmod *oh)
    clk_enable(oh->_clk);

    list_for_each_entry(os, &oh->slave_ports, node) {
    - if (os->_clk && (os->flags & OCPIF_SWSUP_IDLE))
    + if (os->_clk && (os->flags & OCPIF_SWSUP_IDLE)) {
    + omap2_clk_deny_idle(os->_clk);
    clk_enable(os->_clk);
    + }
    }

    /* The opt clocks are controlled by the device driver. */
    @@ -1055,8 +1057,10 @@ static int _disable_clocks(struct omap_hwmod *oh)
    clk_disable(oh->_clk);

    list_for_each_entry(os, &oh->slave_ports, node) {
    - if (os->_clk && (os->flags & OCPIF_SWSUP_IDLE))
    + if (os->_clk && (os->flags & OCPIF_SWSUP_IDLE)) {
    clk_disable(os->_clk);
    + omap2_clk_allow_idle(os->_clk);
    + }
    }

    if (oh->flags & HWMOD_OPT_CLKS_NEEDED)
    @@ -2436,9 +2440,13 @@ static void _setup_iclk_autoidle(struct omap_hwmod *oh)
    continue;

    if (os->flags & OCPIF_SWSUP_IDLE) {
    - /* XXX omap_iclk_deny_idle(c); */
    + /*
    + * we might have multiple users of one iclk with
    + * different requirements, disable autoidle when
    + * the module is enabled, e.g. dss iclk
    + */
    } else {
    - /* XXX omap_iclk_allow_idle(c); */
    + /* we are enabling autoidle afterwards anyways */
    clk_enable(os->_clk);
    }
    }
    --
    2.11.0
    \
     
     \ /
      Last update: 2019-01-16 23:05    [W:4.829 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site