lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms
Date
Vitaly Chikunov <vt@altlinux.org> wrote:

> This will be hard to do since there is at least tree device that use
> this interface (and who know how much out of tree):
>
> drivers$ git grep cra_name.*rsa
> crypto/caam/caampkc.c: .cra_name = "rsa",
> crypto/ccp/ccp-crypto-rsa.c: .cra_name = "rsa",
> crypto/qat/qat_common/qat_asym_algs.c: .cra_name = "rsa",
>
> Interface seems to be designed that verify() call is interchangeable
> with encrypt().
>
> Two verify does not seem that bad since there is common code for the old
> interface that removes code duplication and simplifies driver
> implementation (RSA drivers only need to implement encrypt).

You could move the comparison into core crypto code if it's makes more sense
than moving the comparison to the crypto algorithm ->verify() call. It makes
more sense than the upper layers having to cover the differences between the
algo modules.

David

\
 
 \ /
  Last update: 2019-01-16 17:23    [W:0.074 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site