Messages in this thread | | | From | Jian-Hong Pan <> | Date | Thu, 17 Jan 2019 00:06:14 +0800 | Subject | Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style |
| |
Andreas Färber <afaerber@suse.de> 於 2019年1月16日 週三 下午11:07寫道: > > Am 16.01.19 um 15:33 schrieb Jiri Pirko: > > Wed, Jan 16, 2019 at 03:24:54PM CET, starnight@g.ncu.edu.tw wrote: > >> Signed-off-by: Jian-Hong Pan <starnight@g.ncu.edu.tw> > >> --- > > > > Patches like this are in general frowned upon. Do one change in one > > patch. Put some patch description. > > This patch simply shouldn't have gone to netdev and LKML, as it is a > fixup against a non-stable tree (missing "lora-next"). Once squashed, it > doesn't matter whether it once had a verbose explanation or not. And I > prefer to not mix style and functional changes.
Uh! I see.
Regards, Jian-Hong Pan
> I simply was too impatient to wait for more respins before being able to > base work on it. ;)
| |