Messages in this thread | | | Date | Wed, 16 Jan 2019 16:58:12 +0100 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 2/3] mmc: sdhci-omap: drop ->get_ro() implementation |
| |
Hello,
On Wed, 16 Jan 2019 07:47:18 -0800, Tony Lindgren wrote:
> > Reviewed-by: Thierry Reding <treding@nvidia.com> > > > > Adding Tony and linux-omap for a slightly wider audience and hopefully > > find someone to test this on. For reference, the whole series is here: > > > > https://patchwork.kernel.org/project/linux-mmc/list/?series=66905 > > Thanks Kishon can you please review and test?
I think Adrian's comment that ->get_ro() should be called first in the core code makes sense, so I'll send a v2 with this change. Perhaps testing should be done on the v2 instead, even though I believe it should be functionally equivalent.
Best regards,
Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |