Messages in this thread | | | Subject | Re: [RFC PATCH 5/5] net: lorawan: Split skb definitions into another header | From | Andreas Färber <> | Date | Wed, 16 Jan 2019 15:50:46 +0100 |
| |
Am 16.01.19 um 15:36 schrieb Jiri Pirko: > Wed, Jan 16, 2019 at 03:25:02PM CET, starnight@g.ncu.edu.tw wrote: >> Split LoRaWAN related skb definitions from lora/lorawan_netdev.h into >> another header lora/lorawan_skb.h. > > What is the motivation for this change?
I suggested it because skbs could be used with either LoRa or LoRaWAN netdevs. I have a lora/skb.h.
In general the lorawan_foo.h looks ugly to me, so I thought I suggested to avoid that by using [lora/]lorawan/skb.h?
Regards, Andreas
-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
| |