Messages in this thread | | | From | Boris Brezillon <> | Subject | Re: mtd: gen_probe: Use struct_size() in kmalloc() | Date | Wed, 16 Jan 2019 09:40:53 +0100 |
| |
From: Boris Brezillon <boris.brezillon@bootlin.com>
On Tue, 2019-01-08 at 15:36:01 UTC, "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Boris
| |