lkml.org 
[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface
    Hi Min,

    On Tue, Jan 15, 2019 at 04:19:42PM +0100, Matthias Brugger wrote:
    >
    >
    > On 15/01/2019 02:43, min.guo@mediatek.com wrote:
    > > From: Min Guo <min.guo@mediatek.com>
    > >
    > > Add a common interface for set data toggle
    > >
    > > Signed-off-by: Min Guo <min.guo@mediatek.com>
    > > ---
    > > drivers/usb/musb/musb_host.c | 37 +++++++++++++++++++++++--------------
    > > 1 file changed, 23 insertions(+), 14 deletions(-)
    > >
    > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
    > > index b59ce9a..16d0ba4 100644
    > > --- a/drivers/usb/musb/musb_host.c
    > > +++ b/drivers/usb/musb/musb_host.c
    > > @@ -306,6 +306,25 @@ static inline void musb_save_toggle(struct musb_qh *qh, int is_in,
    > > usb_settoggle(urb->dev, qh->epnum, !is_in, csr ? 1 : 0);
    > > }
    > >
    > > +static inline u16 musb_set_toggle(struct musb_qh *qh, int is_in,
    > > + struct urb *urb)
    > > +{
    > > + u16 csr = 0;
    > > + u16 toggle = 0;
    > > +
    > > + toggle = usb_gettoggle(urb->dev, qh->epnum, !is_in);
    > > +
    > > + if (is_in)
    > > + csr = toggle ? (MUSB_RXCSR_H_WR_DATATOGGLE
    > > + | MUSB_RXCSR_H_DATATOGGLE) : 0;
    > > + else
    > > + csr = toggle ? (MUSB_TXCSR_H_WR_DATATOGGLE
    > > + | MUSB_TXCSR_H_DATATOGGLE)
    > > + : MUSB_TXCSR_CLRDATATOG;
    >
    > Can we switch the if and use is_out logic as function parameter. This would make
    > the code easier to understand.

    based on the current implementation in patch 4/4, I don't think we need
    this separate patch any more, but Matthias' comments still apply.

    Regards,
    -Bin.

    \
     
     \ /
      Last update: 2019-01-15 21:42    [W:3.194 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site