| Subject | Re: [PATCH 04/25] mm, compaction: Remove unnecessary zone parameter in some instances | From | Vlastimil Babka <> | Date | Tue, 15 Jan 2019 12:43:33 +0100 |
| |
On 1/4/19 1:49 PM, Mel Gorman wrote: > A zone parameter is passed into a number of top-level compaction functions > despite the fact that it's already in cache_control. This is harmless but
^ compact_control
> it did need an audit to check if zone actually ever changes meaningfully.
Tried changing the field to "struct zone * const zone;" and it only flagged compact_node() and kcompactd_do_work() which look ok.
> This patches removes the parameter in a number of top-level functions. The > change could be much deeper but this was enough to briefly clarify the > flow. > > No functional change. > > Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
|