Messages in this thread | | | From | Nick Desaulniers <> | Date | Mon, 14 Jan 2019 13:11:52 -0800 | Subject | Re: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler |
| |
On Mon, Jan 14, 2019 at 1:05 PM Tri Vo <trong@android.com> wrote: > > Clang gcov format is only supported by Clang compiler, and Clang > compiler only supports Clang format. > > We set gcov format to depend on which compiler (GCC or Clang) is used. > > Automatic format detection behavior is preserved because: > If GCC is used, one of the GCC gcov formats is selected. > If Clang is used, Clang gcov format is selected. > > Signed-off-by: Tri Vo <trong@android.com>
Thanks for sending the series Tri. I think this config change on the end is a nice little touch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> --- > kernel/gcov/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > index eb428e570923..37ec551d4039 100644 > --- a/kernel/gcov/Kconfig > +++ b/kernel/gcov/Kconfig > @@ -60,6 +60,8 @@ choice > In such a case, change this option to adjust the format used in the > kernel accordingly. > > + Select Clang gcov format if building with Clang compiler. > + > config GCOV_FORMAT_3_4 > bool "GCC 3.4 format" > depends on CC_IS_GCC && GCC_VERSION < 40700 > @@ -68,11 +70,13 @@ config GCOV_FORMAT_3_4 > > config GCOV_FORMAT_4_7 > bool "GCC 4.7 format" > + depends on CC_IS_GCC > ---help--- > Select this option to use the format defined by GCC 4.7. > > config GCOV_FORMAT_CLANG > bool "Clang format" > + depends on CC_IS_CLANG > ---help--- > Select this option to use the format defined by Clang. > > -- > 2.20.1.97.g81188d93c3-goog >
-- Thanks, ~Nick Desaulniers
| |