Messages in this thread | | | Subject | Re: [PATCH] lib/assoc_array: annotate implicit fall through | From | "Gustavo A. R. Silva" <> | Date | Mon, 14 Jan 2019 15:08:46 -0600 |
| |
On 1/14/19 2:24 PM, Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit remove the following warning: > > lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> --- > lib/assoc_array.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/assoc_array.c b/lib/assoc_array.c > index c6659cb37033..0b61d3b77e5c 100644 > --- a/lib/assoc_array.c > +++ b/lib/assoc_array.c > @@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array, > index_key)) > goto found_leaf; > } > + /* fall through */ > case assoc_array_walk_tree_empty: > case assoc_array_walk_found_wrong_shortcut: > default: >
| |