Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 15 Jan 2019 07:32:59 +1200 | Subject | Re: [PATCH] sbitmap: Protect swap_lock from softirqs |
| |
On Tue, Jan 15, 2019 at 5:25 AM Steven Rostedt <rostedt@goodmis.org> wrote: > > The swap_lock used by sbitmap has a chain with locks taken from > softirq, but the swap_lock is not protected from being preempted by > softirqs. > > A chain exists of: > > sbq->ws[i].wait -> dispatch_wait_lock -> swap_lock > > Where the sbq->ws[i].wait lock can be taken from softirq context, which > means all locks below it in the chain must also be protected from > softirqs. > > Cc: stable@vger.kernel.org
Ack and applied, except for the "stable" tag.
Both the original buggy code, and the incorrect "shut up lockdep" were only merged after 4.20.
Linus
| |