Messages in this thread | | | Date | Mon, 14 Jan 2019 15:45:28 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH 2/3] sysrq: Remove duplicated sysrq message |
| |
On Mon 2019-01-14 14:51:27, Sergey Senozhatsky wrote: > On (01/11/19 17:20), Petr Mladek wrote: > > The commit 97f5f0cd8cd0a0544 ("Input: implement SysRq as a separate input > > handler") added pr_fmt() definition. It caused a duplicated message > > prefix in the sysrq header messages, for example: > > > > [ 177.053931] sysrq: SysRq : Show backtrace of all active CPUs > > [ 742.864776] sysrq: SysRq : HELP : loglevel(0-9) reboot(b) crash(c) > > > > Fixes: 97f5f0cd8cd0a05 ("Input: implement SysRq as a separate input handler") > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Thanks.
> A side note: > > > - pr_cont("This sysrq operation is disabled.\n"); > > + pr_info("This sysrq operation is disabled.\n"); > > I wouldn't mind this messages to become more informative. > > + pr_info("sysrq 0x%x operation is disabled.\n", key); > ?
It might be better to use the op_p->action_msg or op_p->help_msg strings instead of the key number.
> A bunch of "This sysrq operation is disabled" in serial0 log file > (post mortem) is not very helpful.
The line is printed with the increased loglevel. It is primary an immediate feedback on the console for the user pressing the sysrq key.
Well, a more descriptive message would not hurt. Anyway, it should be a separate patch.
Best Regards, Petr
| |