Messages in this thread | | | Subject | Re: fix a layering violation in videobuf2 and improve dma_map_resource | From | Marek Szyprowski <> | Date | Mon, 14 Jan 2019 12:43:03 +0100 |
| |
Hi Christoph,
On 2019-01-11 19:17, Christoph Hellwig wrote: > Hi all, > > this series fixes a rather gross layering violation in videobuf2, which > pokes into arm DMA mapping internals to get a DMA address for memory that > does not have a page structure, and to do so fixes up the dma_map_resource > implementation to be practically useful.
Thanks for rewriting this 'temporary code'! It predates dma_map_resource() and that time this was the only way to get it working somehow. Good that now it is possible to implement in it a clean way without any unwritten assumptions about the DMA mapping internals. Feel free to add my:
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
| |