Messages in this thread | | | Date | Tue, 15 Jan 2019 10:18:59 +0800 | From | Wei Wang <> | Subject | Re: [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func |
| |
On 01/15/2019 09:00 AM, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 03:01:05PM +0800, Wei Wang wrote: >> There is no need to update the balloon actual register when there is no >> ballooning request. This patch avoids update_balloon_size when diff is 0. >> >> Signed-off-by: Wei Wang <wei.w.wang@intel.com> >> Reviewed-by: Cornelia Huck <cohuck@redhat.com> >> Reviewed-by: Halil Pasic <pasic@linux.ibm.com> > It sounds reasonable but it does have a side effect of > not writing into actual anymore. > > I am not sure actual never can get out of sync as a result. > > So better deferred, pls send this in the next merge window. >
No problem, it's not urgent to me.
Best, Wei
| |