lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 63/63] drm/vc4: Set ->is_yuv to false when num_planes == 1
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Boris Brezillon <boris.brezillon@bootlin.com>

    commit 2b02a05bdc3a62d36e0d0b015351897109e25991 upstream.

    When vc4_plane_state is duplicated ->is_yuv is left assigned to its
    previous value, and we never set it back to false when switching to
    a non-YUV format.

    Fix that by setting ->is_yuv to false in the 'num_planes == 1' branch
    of the vc4_plane_setup_clipping_and_scaling() function.

    Fixes: fc04023fafecf ("drm/vc4: Add support for YUV planes.")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181009132446.21960-1-boris.brezillon@bootlin.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/vc4/vc4_plane.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/gpu/drm/vc4/vc4_plane.c
    +++ b/drivers/gpu/drm/vc4/vc4_plane.c
    @@ -352,6 +352,7 @@ static int vc4_plane_setup_clipping_and_
    if (vc4_state->is_unity)
    vc4_state->x_scaling[0] = VC4_SCALING_PPF;
    } else {
    + vc4_state->is_yuv = false;
    vc4_state->x_scaling[1] = VC4_SCALING_NONE;
    vc4_state->y_scaling[1] = VC4_SCALING_NONE;
    }

    \
     
     \ /
      Last update: 2019-01-11 16:05    [W:2.723 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site