lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 045/148] w90p910_ether: remove incorrect __init annotation
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 51367e423c6501a26e67d91a655d2bc892303462 ]

    The get_mac_address() function is normally inline, but when it is
    not, we get a warning that this configuration is broken:

    WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address()
    The function w90p910_ether_setup() references
    the function __init get_mac_address().
    This is often because w90p910_ether_setup lacks a __init

    Remove the __init to make it always do the right thing.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/nuvoton/w90p910_ether.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/nuvoton/w90p910_ether.c b/drivers/net/ethernet/nuvoton/w90p910_ether.c
    index 052b3d2c07a1..c662c6f5bee3 100644
    --- a/drivers/net/ethernet/nuvoton/w90p910_ether.c
    +++ b/drivers/net/ethernet/nuvoton/w90p910_ether.c
    @@ -912,7 +912,7 @@ static const struct net_device_ops w90p910_ether_netdev_ops = {
    .ndo_validate_addr = eth_validate_addr,
    };

    -static void __init get_mac_address(struct net_device *dev)
    +static void get_mac_address(struct net_device *dev)
    {
    struct w90p910_ether *ether = netdev_priv(dev);
    struct platform_device *pdev;
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-01-11 15:55    [W:4.390 / U:1.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site