Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 11 Jan 2019 13:33:35 +0100 | Subject | Re: [PATCH v2 2/2] ARM: integrator: impd1: use struct_size() in devm_kzalloc() |
| |
On Sat, Jan 5, 2019 at 6:55 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > Changes in v2: > - Fix devm_kzalloc parameter reported by kbuild test robot.
Patch applied.
Yours, Linus Walleij
| |