lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998
From
Date
On 1/11/2019 12:45 PM, Rob Herring wrote:
> On Fri, Jan 04, 2019 at 09:50:47AM -0700, Jeffrey Hugo wrote:
>> MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845
>> support, however MSM8998 does not have display port (DP) support.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +
>> drivers/phy/qualcomm/phy-qcom-qmp.c | 142 +++++++++++++++++++++
>> drivers/phy/qualcomm/phy-qcom-qmp.h | 4 +
>> 3 files changed, 151 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> index 41a1074..6061b6f 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> @@ -9,6 +9,7 @@ Required properties:
>> "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074
>> "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996,
>> "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
>> + "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,
>
> Please make bindings a separate patch. Combining patch 1 and 2
> binding changes is fine.
>
> Rob
>

Sure. Planning on re-spinning early next week to address a few comments.

--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2019-01-11 20:50    [W:0.066 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site