lkml.org 
[lkml]   [2019]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ASoC: core: Fix deferral of machine drivers
    From
    Date

    On 09/01/2019 18:36, Mark Brown wrote:
    > On Tue, Jan 08, 2019 at 05:28:14PM +0000, Jon Hunter wrote:
    >
    >> --- a/include/sound/soc.h
    >> +++ b/include/sound/soc.h
    >> @@ -925,7 +925,7 @@ struct snd_soc_dai_link {
    >> */
    >> const char *platform_name;
    >> struct device_node *platform_of_node;
    >> - struct snd_soc_dai_link_component *platform;
    >> + struct snd_soc_dai_link_component platform;
    >>
    >> int id; /* optional ID for machine driver link identification */
    >>
    >
    > This breaks the build for the SCU cards (and we needs a little rebase
    > against another fix I just merged, though I did do that when applying).

    Sorry I still don't see the build break, can you point me to it?

    > I do think that this is going to be the safest thing to do for v5.0, it
    > can always be reverted later on when it's not needed but it seems clear
    > that a better fix is going to be way too invasive for the -rcs. Can you
    > respin and retest please?

    Yes will do. I do wonder if we should be concerned about
    snd_soc_init_multicodec() as well? Looks like it could have a different
    problem if a machine driver already allocated the memory for the codec
    link component.

    Cheers
    Jon

    --
    nvpublic

    \
     
     \ /
      Last update: 2019-01-10 13:14    [W:3.284 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site