Messages in this thread | | | Date | Thu, 10 Jan 2019 12:07:07 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails |
| |
On Thu, Jan 10, 2019 at 12:11:17PM +0800, Mark Zhang wrote:
> + /* there is no SW control for rails which are part of FPS > + * set always no contraint to true to avoid regulator > + * enable/disable notification > + */ > + if (pmic->reg_pdata[id].active_fps_src != MAX77620_FPS_SRC_NONE) > + rdev->constraints->always_on = true;
A driver should never modify the constraints, you should register a different set of operations without an enable operation instead and let the framework handle this. [unhandled content-type:application/pgp-signature] | |