lkml.org 
[lkml]   [2019]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: isci: initialize shost fully before calling scsi_add_host()
From
Date
On 09/01/2019 18:41, Christoph Hellwig wrote:
> This looks good. I wonder if there is any good way to prevent other
> drivers from picking up this bug byt using a better interface, but
> that should not delay your fix.
>
> .
>

I noticed that hisi_sas has this same problem but I forgot to fix it.

So how about just drop these APIs and let the user set the shost
protection parameters directly, like other shost parameters, which
should make it a bit clearer when these should be set, i.e. before
scsi_add_host()?

John


\
 
 \ /
  Last update: 2019-01-10 10:13    [W:0.131 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site