Messages in this thread | | | Date | Wed, 2 Jan 2019 00:24:43 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: core: Fix to store new mtu setting in netdevice. |
| |
On Tue, Jan 01, 2019 at 03:18:51PM +0530, Murali Krishna Policharla wrote: > Hi Andrew, > Currently net/dsa/slave.c does not have > ndo_change_mtu function. But shortly I will be submitting a separate > patch outside this fix that has ndo_change_mtu function support added to > DSA switch. As part of testing the newly added ndo_change_mtu function > for DSA switch it uncovered that new mtu size is not being updated to > netdevice structure. This patch fixes this issue and updates new mtu size > to netdevice structure. > > Hope this clarifies, let me know if you need any further information.
Hi Murali
Thanks for the explanation.
However, i looked at the patch you listed as 'fixes'. I don't see what came before that setting the mtu when an ndo_change_mtu function is provided. It seems to me, if you provide an ndo_change_mtu, it has to do the assignment. I don't think you are fixing anything here.
If you do want to move the assignment into the core, please review all the MAC drivers which implement ndo_change_mtu and remove the assignment from them.
Thanks Andrew
| |