lkml.org 
[lkml]   [2019]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] perf record: bind the AIO user space buffers to nodes
On Mon, Dec 24, 2018 at 03:24:36PM +0300, Alexey Budankov wrote:

SNIP

> +static void perf_mmap__aio_free(void **data, size_t len __maybe_unused)
> +{
> + zfree(data);
> +}
> +
> +static void perf_mmap__aio_bind(void *data __maybe_unused, size_t len __maybe_unused,
> + int cpu __maybe_unused, int affinity __maybe_unused)
> +{
> +}
> +#endif
> +
> static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> {
> int delta_max, i, prio;
> @@ -177,11 +220,13 @@ static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> }
> delta_max = sysconf(_SC_AIO_PRIO_DELTA_MAX);
> for (i = 0; i < map->aio.nr_cblocks; ++i) {
> - map->aio.data[i] = malloc(perf_mmap__mmap_len(map));
> + size_t mmap_len = perf_mmap__mmap_len(map);
> + perf_mmap__aio_alloc(&(map->aio.data[i]), mmap_len);
> if (!map->aio.data[i]) {
> pr_debug2("failed to allocate data buffer area, error %m");
> return -1;
> }
> + perf_mmap__aio_bind(map->aio.data[i], mmap_len, map->cpu, mp->affinity);

this all does not work if bind fails.. I think we need to
propagate the error value here and fail

jirka

\
 
 \ /
  Last update: 2019-01-01 22:42    [W:0.525 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site