Messages in this thread | | | Date | Sun, 9 Sep 2018 18:45:30 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs |
| |
On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: > No, you get a different warning depending on whether you have enabled > CONFIG_PARAVIRT_TIME_ACCOUNTING or CONFIG_IRQ_TIME_ACCOUNTING.
Ok.
Still, adding __maybe_unused to both (or writing it before the name, whatever works!) and dropping the ifdeffery is still better for readability's sake than having more ifdeffery, IMO.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |