Messages in this thread | | | Subject | Re: [PATCH RFC 3/5] coccinelle: add xxxsetbitsXX converting spatch | From | SF Markus Elfring <> | Date | Sun, 9 Sep 2018 13:13:25 +0200 |
| |
How do you think about to add any more meta-data for this semantic patch script?
* SPDX identifier * Copyright information * Confidence level
https://bottest.wiki.kernel.org/coccicheck
> +virtual context
Further variables will be needed if you would like to use corresponding operation modes (besides “patch”).
> +expression reg; > +expression set; > +expression clear;
I propose once more to avoid the repetition of (unnecessary) SmPL code. This part could be written like the following instead.
+expression clear, set, reg;
If you would increase the usage of SmPL disjunctions, the specification of duplicate SmPL code could be reduced considerably.
* Would you like to merge SmPL rules based on the distinction between the data types “u32” and “u64”?
* Did you identify any optional code in this transformation approach?
> +@@ > +expression base; > +expression offset; > +expression value; > +@@ > + > +- mtu3_setbits(base, offset, value); > ++ setbits32(base + offset, value); > + > +@@ > +expression base; > +expression offset; > +expression mask; > +@@ > + > +- mtu3_clrbits(base, offset, mask); > ++ clrbits32(base + offset, mask);
Another update suggestion:
+@replacement@ +expression base, offset; +@@ +( +-mtu3_clrbits ++clrbits32 +| +-mtu3_setbits ++setbits32 +)(base +- , ++ + + offset, ...);
Would you like to try further software fine-tuning out?
Regards, Markus
| |