Messages in this thread | | | Date | Sat, 8 Sep 2018 15:00:55 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 1/2] s390: vmlogrdr: Use ARRAY_SIZE instead of reimplementing its function |
| |
On Sat, 8 Sep 2018 18:26:27 +0800, zhong jiang wrote: > ARRAY_SIZE has implemented its function. we prefer to use the function > rather than the open code. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/s390/char/vmlogrdr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c > index 069b9ef..58333cb 100644 > --- a/drivers/s390/char/vmlogrdr.c > +++ b/drivers/s390/char/vmlogrdr.c > @@ -153,7 +153,7 @@ static void vmlogrdr_iucv_message_pending(struct iucv_path *, > } > }; > > -#define MAXMINOR (sizeof(sys_ser)/sizeof(struct vmlogrdr_priv_t)) > +#define MAXMINOR ARRAY_SIZE(sys_ser) > > static char FENCE[] = {"EOR"}; > static int vmlogrdr_major = 0;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
-- Jean Delvare SUSE L3 Support
| |